Messages in this thread | | | Date | Thu, 14 Dec 2006 13:05:57 -0800 (PST) | From | Doug Thompson <> | Subject | Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core |
| |
--- Alan <alan@lxorguk.ukuu.org.uk> wrote:
> > > +void edac_mc_handle_fbd_ue(struct mem_ctl_info *mci, > > + unsigned int csrow, > > + unsigned int channela, > > + unsigned int channelb, > > + char *msg) > > +{ > > + int len = EDAC_MC_LABEL_LEN * 4; > > + char labels[len + 1]; > > Have you checked gcc generates the right code from this and not a > dynamic > allocation. I'm not sure if you want "const int len" to force that ?
good question
I looked at the output for this and the 'edac_c_handle_ue()' function from which this function was copied, and both adjust the stack pointer and do not call for dynamic allocation.
An old guy's old method explored.
thanks for the sanity check
doug t
> > > Otherwise looks ok >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |