Messages in this thread | | | Date | Thu, 14 Dec 2006 10:58:09 +0000 | From | Alan <> | Subject | Re: [PATCH 3/3] EDAC: Add Fully-Buffered DIMM APIs to core |
| |
> +void edac_mc_handle_fbd_ue(struct mem_ctl_info *mci, > + unsigned int csrow, > + unsigned int channela, > + unsigned int channelb, > + char *msg) > +{ > + int len = EDAC_MC_LABEL_LEN * 4; > + char labels[len + 1];
Have you checked gcc generates the right code from this and not a dynamic allocation. I'm not sure if you want "const int len" to force that ?
Otherwise looks ok - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |