Messages in this thread | | | Subject | arch/s390/lib/uaccess_pt.c: Missing breaks: ? | From | Joe Perches <> | Date | Sat, 13 Apr 2013 23:06:14 -0700 |
| |
Hello Heiko.
Commit ea81531d ("s390/uaccess: fix page table walk") added this code. It looks like it should have break; for each case.
------------
static unsigned long follow_table(struct mm_struct *mm, unsigned long address, int write) { unsigned long *table = (unsigned long *)__pa(mm->pgd);
switch (mm->context.asce_bits & _ASCE_TYPE_MASK) { case _ASCE_TYPE_REGION1: table = table + ((address >> 53) & 0x7ff); if (unlikely(*table & _REGION_ENTRY_INV)) return -0x39UL; table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN); case _ASCE_TYPE_REGION2: table = table + ((address >> 42) & 0x7ff); if (unlikely(*table & _REGION_ENTRY_INV)) return -0x3aUL; table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN); case _ASCE_TYPE_REGION3: table = table + ((address >> 31) & 0x7ff); if (unlikely(*table & _REGION_ENTRY_INV)) return -0x3bUL; table = (unsigned long *)(*table & _REGION_ENTRY_ORIGIN); case _ASCE_TYPE_SEGMENT: table = table + ((address >> 20) & 0x7ff); if (unlikely(*table & _SEGMENT_ENTRY_INV)) return -0x10UL; if (unlikely(*table & _SEGMENT_ENTRY_LARGE)) { if (write && (*table & _SEGMENT_ENTRY_RO)) return -0x04UL; return (*table & _SEGMENT_ENTRY_ORIGIN_LARGE) + (address & ~_SEGMENT_ENTRY_ORIGIN_LARGE); } table = (unsigned long *)(*table & _SEGMENT_ENTRY_ORIGIN); }
| |