lkml.org 
[lkml]   [2024]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv
On Mon, 29 Apr 2024, Christophe JAILLET wrote:

> Le 29/04/2024 à 10:13, AngeloGioacchino Del Regno a écrit :
> > Il 28/04/24 20:27, Christophe JAILLET ha scritto:
> > > In "struct mt6370_priv", the 'reg_cfgs' field is unused.
> > >
> > > Moreover the "struct reg_cfg" is defined nowhere. Neither in this
> > > file, nor
> > > in a global .h file, so it is completely pointless.
> > >
> > > Remove it.
> >
> > Sure
> >
> > >
> > > Found with cppcheck, unusedStructMember.
> > >
> > > So, remove it.
> >
> > Again?! :-P
>
> Yes. This way we safe twice the memory space :).

I changed all of the commit messages in this disjointed set to flow a
little better. No need for a Fixes tag either I feel.

--
Lee Jones [李琼斯]

\
 
 \ /
  Last update: 2024-05-27 18:14    [W:0.364 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site