Messages in this thread | | | Date | Mon, 29 Apr 2024 10:13:42 +0200 | Subject | Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv | From | AngeloGioacchino Del Regno <> |
| |
Il 28/04/24 20:27, Christophe JAILLET ha scritto: > In "struct mt6370_priv", the 'reg_cfgs' field is unused. > > Moreover the "struct reg_cfg" is defined nowhere. Neither in this file, nor > in a global .h file, so it is completely pointless. > > Remove it.
Sure
> > Found with cppcheck, unusedStructMember. > > So, remove it.
Again?! :-P
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Anyway, this commit misses a Fixes tag; please add the relevant one, after which,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> --- > Compile tested only. > --- > drivers/leds/rgb/leds-mt6370-rgb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c > index 448d0da11848..359ef00498b4 100644 > --- a/drivers/leds/rgb/leds-mt6370-rgb.c > +++ b/drivers/leds/rgb/leds-mt6370-rgb.c > @@ -149,7 +149,6 @@ struct mt6370_priv { > struct regmap_field *fields[F_MAX_FIELDS]; > const struct reg_field *reg_fields; > const struct linear_range *ranges; > - struct reg_cfg *reg_cfgs; > const struct mt6370_pdata *pdata; > unsigned int leds_count; > unsigned int leds_active;
| |