Messages in this thread | | | Date | Thu, 2 May 2024 10:01:02 +0300 | From | Dan Carpenter <> | Subject | Re: [net-next PATCH v3 3/9] octeontx2-pf: Create representor netdev |
| |
On Wed, May 01, 2024 at 07:06:56PM +0100, Simon Horman wrote: > > + goto exit; > > + } > > + } > > + err = rvu_rep_napi_init(priv, extack); > > + if (err) > > + goto exit; > > Even with the above fixed, Smatch complains that: > > .../rep.c:180 rvu_rep_create() warn: 'ndev' from alloc_etherdev_mqs() not released on lines: 180. > .../rep.c:180 rvu_rep_create() warn: 'ndev' from register_netdev() not released on lines: 180. > > Where line 180 is the very last line of the funciton: return err; > > I think this is triggered by the error handling above. > However, I also think it is a false positive. > I've CCed Dan Carpenter as I'd value a second opinion on this one. >
Yeah. It's a false positive.
regards, dan carpenter
| |