lkml.org 
[lkml]   [2024]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
Subjectpcie-mediatek slot calculation correct?
Hi all,

I was doing Conf Type 0/1 helper generalization when I ran into this code
in drivers/pci/controller/pcie-mediatek.c:

u32 func = PCI_FUNC(port->slot);
u32 slot = PCI_SLOT(port->slot << 3);

With that code, function is effectively duplicated into slot, is this
correct behavior?

..Adjustments made in the history of this code fragment didn't exactly
inspire confidence on the correctness of this code. :-/


--
i.


\
 
 \ /
  Last update: 2024-04-29 12:23    [W:0.021 / U:1.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site