lkml.org 
[lkml]   [2024]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH] spi: dt-bindings: ti,qspi: convert to dtschema
From
On 29/04/2024 09:10, Kousik Sanagavarapu wrote:
> On Mon, Apr 29, 2024 at 07:07:38AM +0200, Krzysztof Kozlowski wrote:
>> On 28/04/2024 08:58, Kousik Sanagavarapu wrote:
>>> Convert txt binding of TI's qspi controller (found on their omap SoCs) to
>>> dtschema to allow for validation.
>
> [...]
>
>>> + spi-max-frequency:
>>> + description: Maximum SPI clocking speed of the controller in Hz.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>
>>
>> Are you sure that's actually needed? That's not a property of controller.
>
> [...]
>
>>> + num-cs = <4>;
>>> + spi-max-frequency = <48000000>;
>>
>> Drop. Are you sure driver parses it?
>
> The driver does parse it though. Looking at
> drivers/spi/spi-ti-qspi.c::ti_qspi_probe(),
>
> if (!of_property_read_u32(np, "spi-max-frequency", &max_freq))
> host->max_speed_hz = max_freq;
>
> So I included it in the dtschema as well. Please let me know if
> including it in the dtschema in this case is wrong.

Ah, indeed. It is fine there. Keep it in the binidng and in the example.

Best regards,
Krzysztof


\
 
 \ /
  Last update: 2024-04-29 09:25    [W:1.047 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site