lkml.org 
[lkml]   [2024]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] spi: dt-bindings: ti,qspi: convert to dtschema
On Mon, Apr 29, 2024 at 07:07:38AM +0200, Krzysztof Kozlowski wrote:
> On 28/04/2024 08:58, Kousik Sanagavarapu wrote:
> > Convert txt binding of TI's qspi controller (found on their omap SoCs) to
> > dtschema to allow for validation.

[...]

> > + spi-max-frequency:
> > + description: Maximum SPI clocking speed of the controller in Hz.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
>
> Are you sure that's actually needed? That's not a property of controller.

[...]

> > + num-cs = <4>;
> > + spi-max-frequency = <48000000>;
>
> Drop. Are you sure driver parses it?

The driver does parse it though. Looking at
drivers/spi/spi-ti-qspi.c::ti_qspi_probe(),

if (!of_property_read_u32(np, "spi-max-frequency", &max_freq))
host->max_speed_hz = max_freq;

So I included it in the dtschema as well. Please let me know if
including it in the dtschema in this case is wrong.

Thanks

\
 
 \ /
  Last update: 2024-05-27 18:07    [W:0.081 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site