lkml.org 
[lkml]   [2024]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: mfd: dlg,da9063: Make #interrupt-cells required
Hey,

On Wed, Feb 14, 2024 at 04:03:42PM +0100, Geert Uytterhoeven wrote:
> '#interrupt-cells' is a required property for interrupt providers, hence
> make it required.

I actually meant to send this patch yesterday but I forgot, thanks for
doing it - the only riscv violation of what Rob reported was also a
da9063..

> While at it, move '#interrupt-cells' in the example to match common sort
> order.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

I think:
Fixes: 361104b05684 ("dt-bindings: mfd: Convert da9063 to yaml")

and
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
> Documentation/devicetree/bindings/mfd/dlg,da9063.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> index c5a7e10d7d80e8d7..e5ccc2708f0bb0f8 100644
> --- a/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9063.yaml
> @@ -87,6 +87,7 @@ required:
> - reg
> - interrupts
> - interrupt-controller
> + - '#interrupt-cells'
>
> additionalProperties: false
>
> @@ -99,10 +100,10 @@ examples:
> pmic@58 {
> compatible = "dlg,da9063";
> reg = <0x58>;
> - #interrupt-cells = <2>;
> interrupt-parent = <&gpio6>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> interrupt-controller;
> + #interrupt-cells = <2>;
>
> rtc {
> compatible = "dlg,da9063-rtc";
> --
> 2.34.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 15:02    [W:0.023 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site