Messages in this thread | | | Date | Wed, 14 Feb 2024 14:20:37 +0100 | From | Gregor Herburger <> | Subject | Re: [PATCH v6 net-next 05/14] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2220 PHY |
| |
Hi Dimitri,
On Tue, Feb 13, 2024 at 10:39:44PM +0100, Dimitri Fedrau wrote: > static struct phy_driver mv88q2xxx_driver[] = { > { > .phy_id = MARVELL_PHY_ID_88Q2110, > @@ -255,12 +439,26 @@ static struct phy_driver mv88q2xxx_driver[] = { > .get_sqi = mv88q2xxx_get_sqi, > .get_sqi_max = mv88q2xxx_get_sqi_max, > }, > + { > + PHY_ID_MATCH_EXACT(PHY_ID_88Q2220_REVB0),
I tested the series on a 88Q2220 REV B1 (which is id 0x002b0b22). The driver works fine on this revision.
I understand that in the Marvell API the initialization for Rev B0 and B1 differ. For B0 some additional init sequence is executed. I did not look into the details of this sequence. However this patch seems to work on Rev B1.
Would you consider adding compatibility for Rev B1 and following? I tested with: .phy_id = MARVELL_PHY_ID_88Q2220, .phy_id_mask = MARVELL_PHY_ID_MASK,
Otherwise:
Tested-by: Gregor Herburger <gregor.herburger@ew.tq-group.com>
Best regards Gregor -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider https://www.tq-group.com/
| |