Messages in this thread | | | Date | Wed, 14 Feb 2024 18:54:58 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v6 net-next 09/14] net: phy: marvell-88q2xxx: add cable test support |
| |
> +static int mv88q222x_cable_test_get_status(struct phy_device *phydev, > + bool *finished) > +{ > + int ret; > + u32 dist; > + > + ret = phy_read_mmd(phydev, MDIO_MMD_PCS, MDIO_MMD_PCS_MV_TDR_STATUS); > + if (ret < 0) > + return ret; > + > + *finished = true;
That looks odd. Is there no status bit which says it has completed? Is it guaranteed to complete within a fixed time? How is it guaranteed that mv88q222x_cable_test_get_status() is called at the necessary delay after mv88q222x_cable_test_start()?
Andrew
| |