| Date | Thu, 10 Jun 2021 19:59:05 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH v9 18/22] media: uvcvideo: Downgrade control error messages |
| |
Hi Ricardo,
Thank you for the patch.
On Fri, Mar 26, 2021 at 10:58:36AM +0100, Ricardo Ribalda wrote: > Convert the error into a debug message, so they are still valid for > debugging but do not fill dmesg.
This isn't supposed to happen, doesn't it deserve an error message ?
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/usb/uvc/uvc_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index ea2903dc3252..b63c073ec30e 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -76,7 +76,7 @@ int uvc_query_ctrl(struct uvc_device *dev, u8 query, u8 unit, > if (likely(ret == size)) > return 0; > > - dev_err(&dev->udev->dev, > + dev_dbg(&dev->udev->dev, > "Failed to query (%s) UVC control %u on unit %u: %d (exp. %u).\n", > uvc_query_name(query), cs, unit, ret, size); >
-- Regards,
Laurent Pinchart
|