| Date | Thu, 10 Jun 2021 19:57:37 +0300 | From | Laurent Pinchart <> | Subject | Re: [PATCH v9 21/22] uvcvideo: don't spam the log in uvc_ctrl_restore_values() |
| |
Hi Ricardo and Hans,
Thank you for the patch.
On Fri, Mar 26, 2021 at 10:58:39AM +0100, Ricardo Ribalda wrote: > From: Hans Verkuil <hverkuil-cisco@xs4all.nl> > > Don't report the restored controls with dev_info, use dev_dbg instead. > This prevents a lot of noise in the kernel log. > > Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> --- > drivers/media/usb/uvc/uvc_ctrl.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c > index 6e7b904bc33d..df6c33932557 100644 > --- a/drivers/media/usb/uvc/uvc_ctrl.c > +++ b/drivers/media/usb/uvc/uvc_ctrl.c > @@ -2182,10 +2182,10 @@ int uvc_ctrl_restore_values(struct uvc_device *dev) > if (!ctrl->initialized || !ctrl->modified || > (ctrl->info.flags & UVC_CTRL_FLAG_RESTORE) == 0) > continue; > - dev_info(&dev->udev->dev, > - "restoring control %pUl/%u/%u\n", > - ctrl->info.entity, ctrl->info.index, > - ctrl->info.selector); > + dev_dbg(&dev->udev->dev, > + "restoring control %pUl/%u/%u\n", > + ctrl->info.entity, ctrl->info.index, > + ctrl->info.selector); > ctrl->dirty = 1; > } >
-- Regards,
Laurent Pinchart
|