Messages in this thread Patch in this message | | | Date | Tue, 3 May 2011 21:28:31 -0400 (EDT) | From | "Robert P. J. Day" <> | Subject | [PATCH] RAW driver: Remove call to kobject_put(). |
| |
If cdev_add() fails, there is no justification for subsequently calling kobject_put().
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
===
diff --git a/drivers/char/raw.c b/drivers/char/raw.c index b4b9d5a..e2b4829 100644 --- a/drivers/char/raw.c +++ b/drivers/char/raw.c @@ -319,7 +319,6 @@ static int __init raw_init(void) cdev_init(&raw_cdev, &raw_fops); ret = cdev_add(&raw_cdev, dev, MAX_RAW_MINORS); if (ret) { - kobject_put(&raw_cdev.kobj); goto error_region; }
--
======================================================================== Robert P. J. Day Ottawa, Ontario, CANADA http://crashcourse.ca Twitter: http://twitter.com/rpjday LinkedIn: http://ca.linkedin.com/in/rpjday ========================================================================
| |