Messages in this thread | | | Subject | Re: [Stable-review] [36/55] [PARISC] slub: fix panic with DISCONTIGMEM | From | James Bottomley <> | Date | Tue, 03 May 2011 18:20:45 -0500 |
| |
On Wed, 2011-05-04 at 00:17 +0100, Ben Hutchings wrote: > On Tue, May 03, 2011 at 03:46:13PM -0700, David Rientjes wrote: > [...] > > SLUB relies heavily on N_NORMAL_MEMORY, so these two patches fix that > > allocator but the problem is actually not just isolated to that subsystem; > > it fixes an issue with anything that uses N_NORMAL_MEMORY. > > > > The former patch sets the nodes correctly for parisc and Michael's patch > > sets the nodes correctly for m68k, so it's the same fix for two different > > previously-broken architectures. > > So if I understand you correctly, the Kconfig condition for SLUB is > now wrong - only architectures that use DISCONTIGMEM's fake-NUMA and > don't set the node states to N_NORMAL_MEMORY will break it.
No, that's not correct; parisc does all of that and still oopses in SLUB on range > 0 allocations.
I'm not sure why m68k works ... as far as I can tell, the page_to_nid() issue should trip them as well.
James
| |