Messages in this thread | | | Date | Wed, 4 May 2011 00:17:22 +0100 | From | Ben Hutchings <> | Subject | Re: [Stable-review] [36/55] [PARISC] slub: fix panic with DISCONTIGMEM |
| |
On Tue, May 03, 2011 at 03:46:13PM -0700, David Rientjes wrote: [...] > SLUB relies heavily on N_NORMAL_MEMORY, so these two patches fix that > allocator but the problem is actually not just isolated to that subsystem; > it fixes an issue with anything that uses N_NORMAL_MEMORY. > > The former patch sets the nodes correctly for parisc and Michael's patch > sets the nodes correctly for m68k, so it's the same fix for two different > previously-broken architectures.
So if I understand you correctly, the Kconfig condition for SLUB is now wrong - only architectures that use DISCONTIGMEM's fake-NUMA and don't set the node states to N_NORMAL_MEMORY will break it. And there's no good way to test for that in Kconfig.
Ben.
-- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus
| |