Messages in this thread | | | Date | Fri, 3 May 2024 11:31:16 +0200 | From | Jan Kara <> | Subject | Re: [PATCH v2 3/4] mm: call __wb_calc_thresh instead of wb_calc_thresh in wb_over_bg_thresh |
| |
On Thu 25-04-24 21:17:23, Kemeng Shi wrote: > Call __wb_calc_thresh to calculate wb bg_thresh of gdtc in > wb_over_bg_thresh to remove unnecessary wrap in wb_calc_thresh. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> --- > mm/page-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 14893b20d38c..22e1acec899e 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -2117,7 +2117,7 @@ bool wb_over_bg_thresh(struct bdi_writeback *wb) > if (gdtc->dirty > gdtc->bg_thresh) > return true; > > - thresh = wb_calc_thresh(gdtc->wb, gdtc->bg_thresh); > + thresh = __wb_calc_thresh(gdtc, gdtc->bg_thresh); > if (thresh < 2 * wb_stat_error()) > reclaimable = wb_stat_sum(wb, WB_RECLAIMABLE); > else > -- > 2.30.0 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |