Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Apr 2024 17:10:25 +0300 | Subject | Re: [PATCH v2 1/2] dt-bindings: mtd: amlogic,meson-nand: support fields for boot ROM code | From | Arseniy Krasnov <> |
| |
On 09.04.2024 16:47, Rob Herring wrote: > On Mon, Apr 08, 2024 at 11:59:30AM +0300, Arseniy Krasnov wrote: >> Boot ROM code on Meson requires that some pages on NAND must be written >> in special mode: "short" ECC mode where each block is 384 bytes and >> scrambling mode is on. Such pages located with the specified interval >> within specified offset. Both interval and offset are located in the >> device tree and used by driver if 'nand-is-boot-medium' is set for >> NAND chip. >> >> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com> >> --- >> .../bindings/mtd/amlogic,meson-nand.yaml | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> index 57b6957c8415..80ba5003ca70 100644 >> --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml >> @@ -64,11 +64,25 @@ patternProperties: >> items: >> maximum: 0 >> >> + amlogic,boot-page-last: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The NFC driver needs this information to select ECC >> + algorithms supported by the boot ROM. >> + >> + amlogic,boot-page-step: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + description: >> + The NFC driver needs this information to select ECC >> + algorithms supported by the boot ROM (in pages). >> + >> unevaluatedProperties: false >> >> dependencies: >> nand-ecc-strength: [nand-ecc-step-size] >> nand-ecc-step-size: [nand-ecc-strength] >> + amlogic,boot-page-last: [nand-is-boot-medium, amlogic,boot-page-step] >> + amlogic,boot-page-step: [nand-is-boot-medium, amlogic,boot-page-last] > > You need quotes if using the inline syntax.
IIUC it must look like this:
amlogic,boot-page-last: [nand-is-boot-medium, "amlogic,boot-page-step"]
etc.
> > Rob
| ![\](/images/icornerr.gif) |