Messages in this thread | | | Date | Tue, 9 Apr 2024 10:02:20 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v4 6/9] net: dsa: microchip: dcb: add special handling for KSZ88X3 family |
| |
Hi Arun,
On Mon, Apr 08, 2024 at 04:26:34PM +0000, Arun.Ramadoss@microchip.com wrote: > Hi Oleksij, > > + * Return: 0 on success, or a negative error code on failure > > + */ > > +static int ksz88x3_port0_apptrust_quirk(struct ksz_device *dev, int > > port, > > + int reg, u8 data) > > +{ > > + u8 port1_data; > > why can't we have some common reference, because it is somewhat > confusing. function name is port0, but apptrust config is for port1 and > u8 port1_data. atleast instead of port1_data, port0_data, we can have > variable name as data, since they are handled in two different > functions.
Ack, I renamed variables and functions to be more in sync with the documentation and add defines for ports
Is it possible to add this erratum to the chip errata documentation?
Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |