Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Apr 2024 09:52:10 +0200 | Subject | Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device tree | From | Michael Opdenacker <> |
| |
Hi Inochi
Thanks for the review and tips!
On 4/9/24 at 09:17, Inochi Amaoto wrote: > On Tue, Apr 09, 2024 at 08:45:04AM +0200, michael.opdenacker@bootlin.com wrote: >> From: Michael Opdenacker <michael.opdenacker@bootlin.com> >> >> This adds initial support for the Milk-V Duo S board >> (https://milkv.io/duo-s), enabling the serial port and >> read-only SD card support, allowing to boot Linux to the >> command line. >> > Hi Michael, > > I think your patch losts the board binding and have wrong compatiable. > Also, the SD can have rw support with proper property. See link [1] > (need 'disable-wp').
Right, ""sophgo,sg2000" doesn't exist yet, so it will be indeed cleaner to use "sophgo,cv1812h" instead.
> > I suggest you resubmitting this patch after applying clk patchs. > This could reduce some unnecessary change. For now, you can just > use the dts for huashan-pi (with changed memory size). > > [1]: https://lore.kernel.org/linux-riscv/IA1PR20MB4953B158F6F575840F3D4267BB7D2@IA1PR20MB4953.namprd20.prod.outlook.com/
Good to know. That was next on my list. I'll submit a V2 in the next days. Thanks again Cheers Michael.
-- Michael Opdenacker, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| ![\](/images/icornerr.gif) |