Messages in this thread | | | Date | Tue, 9 Apr 2024 22:02:32 +0200 | Subject | Re: [PATCH v3 1/2] dt-bindings: dma: fsl-edma: remove 'clocks' from required | From | Krzysztof Kozlowski <> |
| |
On 09/04/2024 20:54, Frank Li wrote: > fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from > required and add 'if' block for other compatible string to keep the same > restrictions. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v2 to v3 > - rebase to dmaengine/next
This fails...
> > diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > index 825f4715499e5..657a7d3ebf857 100644 > --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml > +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml > @@ -82,7 +82,6 @@ required: > - compatible > - reg > - interrupts > - - clocks > - dma-channels > > allOf: > @@ -187,6 +186,22 @@ allOf: > "#dma-cells": > const: 3 > > + - if: > + properties: > + compatible: > + contains:
It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint.
Best regards, Krzysztof
| |