Messages in this thread | | | Date | Sun, 7 Apr 2024 19:53:01 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next 2/2] net: lan743x: Fixup EEE |
| |
On Sat, Apr 06, 2024 at 03:16:00PM -0500, Andrew Lunn wrote: > The enabling/disabling of EEE in the MAC should happen as a result of > auto negotiation. So move the enable/disable into > lan743x_phy_link_status_change() which gets called by phylib when > there is a change in link status. > > lan743x_ethtool_set_eee() now just programs the hardware with the LTI > timer value, and passed everything else to phylib, so it can correctly > setup the PHY. > > lan743x_ethtool_get_eee() relies on phylib doing most of the work, the > MAC driver just adds the LTI timer value. > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Probably same as lan78xx - if something is wrong, it was before this patch.
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |