Messages in this thread | | | Date | Sun, 07 Apr 2024 19:46:31 +0200 | From | Dragan Simic <> | Subject | Re: [PATCH] arm64: dts: rockchip: mark system power controller and fix typo on orangepi-5-plus |
| |
On 2024-04-07 19:32, efectn@6tel.net wrote: > From: Muhammed Efe Cetin <efectn@protonmail.com> > > Mark the PMIC as system power controller, so the board will shut-down > properly and fix the typo on rk806_dvs1_null pins property. > > Fixes: 236d225e1ee7 ("arm64: dts: rockchip: Add board device tree for > rk3588-orangepi-5-plus") > Signed-off-by: Muhammed Efe Cetin <efectn@protonmail.com>
Looking good to me.
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> --- > arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > index 1b606ea5b6cf..1a604429fb26 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > @@ -485,6 +485,7 @@ pmic@0 { > pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>, > <&rk806_dvs2_null>, <&rk806_dvs3_null>; > spi-max-frequency = <1000000>; > + system-power-controller; > > vcc1-supply = <&vcc5v0_sys>; > vcc2-supply = <&vcc5v0_sys>; > @@ -506,7 +507,7 @@ pmic@0 { > #gpio-cells = <2>; > > rk806_dvs1_null: dvs1-null-pins { > - pins = "gpio_pwrctrl2"; > + pins = "gpio_pwrctrl1"; > function = "pin_fun0"; > };
| |