Messages in this thread Patch in this message | | | Date | Fri, 05 Apr 2024 12:27:58 +0200 | From | Peter Zijlstra <> | Subject | [RFC][PATCH 04/10] sched/fair: Cleanup pick_task_fair()s curr |
| |
With 4c456c9ad334 ("sched/fair: Remove unused 'curr' argument from pick_next_entity()") curr is no longer being used, so no point in clearing it.
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> --- kernel/sched/fair.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
--- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8427,15 +8427,9 @@ static struct task_struct *pick_task_fai return NULL; do { - struct sched_entity *curr = cfs_rq->curr; - /* When we pick for a remote RQ, we'll not have done put_prev_entity() */ - if (curr) { - if (curr->on_rq) - update_curr(cfs_rq); - else - curr = NULL; - } + if (cfs_rq->curr && cfs_rq->curr->on_rq) + update_curr(cfs_rq); if (unlikely(check_cfs_rq_runtime(cfs_rq))) goto again;
| |