Messages in this thread | | | Date | Thu, 4 Apr 2024 22:29:14 +0530 | Subject | Re: [PATCH] sched/fair: Fix update of rd->sg_overutilized | From | Shrikanth Hegde <> |
| |
On 4/4/24 9:27 PM, Vincent Guittot wrote: > sg_overloaded is used instead of sg_overutilized to update > rd->sg_overutilized.
Yes. Good find. I missed to notice this as well.
> > Fixes: 4475cd8bfd9b ("sched/balancing: Simplify the sg_status bitmask and use separate ->overloaded and ->overutilized flags") > Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 1dd37168da50..bb1ae4ed0d91 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -10661,7 +10661,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd > set_rd_overloaded(env->dst_rq->rd, sg_overloaded); > > /* Update over-utilization (tipping point, U >= 0) indicator */ > - set_rd_overutilized(env->dst_rq->rd, sg_overloaded); > + set_rd_overutilized(env->dst_rq->rd, sg_overutilized); > } else if (sg_overutilized) { > set_rd_overutilized(env->dst_rq->rd, sg_overutilized); > }
Reviewed-by: Shrikanth Hegde <sshegde@linux.ibm.com>
| |