Messages in this thread | | | Date | Mon, 29 Apr 2024 20:23:31 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v5 10/10] ethtool: Veto some operations during firmware flashing process |
| |
On Wed, 24 Apr 2024 16:30:23 +0300 Danielle Ratson wrote: > Some operations cannot be performed during the firmware flashing process. > > For example: > > - Port must be down during the whole flashing process to avoid packet loss > while committing reset for example. > > - Writing to EEPROM interrupts the flashing process, so operations like > ethtool dump, module reset, get and set power mode should be vetoed. > > - Split port firmware flashing should be vetoed. > > - Flashing firmware on a device which is already in a flashing process > should be forbidden. > > Use the 'module_fw_flashing_in_progress' flag introduced in a previous > patch to veto those operations and prevent interruptions while preforming > module firmware flash.
Feels a little out of order to add this check after the functionality. I'd merge this with patch 5.
| |