lkml.org 
[lkml]   [2024]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 08/15] i2c: stm32f4: use 'time_left' variable with wait_for_completion_timeout()
    Date
    There is a confusing pattern in the kernel to use a variable named 'timeout' to
    store the result of wait_for_completion_timeout() causing patterns like:

    timeout = wait_for_completion_timeout(...)
    if (!timeout) return -ETIMEDOUT;

    with all kinds of permutations. Use 'time_left' as a variable to make the code
    self explaining.

    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    ---
    drivers/i2c/busses/i2c-stm32f4.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
    index 859ac0cf7f6c..f8b12be6ef55 100644
    --- a/drivers/i2c/busses/i2c-stm32f4.c
    +++ b/drivers/i2c/busses/i2c-stm32f4.c
    @@ -681,7 +681,7 @@ static int stm32f4_i2c_xfer_msg(struct stm32f4_i2c_dev *i2c_dev,
    {
    struct stm32f4_i2c_msg *f4_msg = &i2c_dev->msg;
    void __iomem *reg = i2c_dev->base + STM32F4_I2C_CR1;
    - unsigned long timeout;
    + unsigned long time_left;
    u32 mask;
    int ret;

    @@ -706,11 +706,11 @@ static int stm32f4_i2c_xfer_msg(struct stm32f4_i2c_dev *i2c_dev,
    stm32f4_i2c_set_bits(reg, STM32F4_I2C_CR1_START);
    }

    - timeout = wait_for_completion_timeout(&i2c_dev->complete,
    - i2c_dev->adap.timeout);
    + time_left = wait_for_completion_timeout(&i2c_dev->complete,
    + i2c_dev->adap.timeout);
    ret = f4_msg->result;

    - if (!timeout)
    + if (!time_left)
    ret = -ETIMEDOUT;

    return ret;
    --
    2.43.0

    \
     
     \ /
      Last update: 2024-04-27 22:38    [W:3.612 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site