Messages in this thread | | | Date | Fri, 26 Apr 2024 09:56:31 -0500 | Subject | Re: [PATCH v2 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD | From | "Moger, Babu" <> |
| |
Hi Ilpo,
On 4/26/2024 2:06 AM, Ilpo Järvinen wrote: > On Thu, 25 Apr 2024, Babu Moger wrote: > >> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is >> available on the system. Tests will be skipped otherwise. >> >> Update noncont_cat_run_test to check for vendor. AMD supports >> non contiguous CBM masks but does not report it via CPUID. >> >> Signed-off-by: Babu Moger <babu.moger@amd.com> >> --- >> tools/testing/selftests/resctrl/cat_test.c | 2 +- >> tools/testing/selftests/resctrl/mba_test.c | 1 - >> tools/testing/selftests/resctrl/mbm_test.c | 1 - >> 3 files changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c >> index 4cb991be8e31..b682eaf65bfd 100644 >> --- a/tools/testing/selftests/resctrl/cat_test.c >> +++ b/tools/testing/selftests/resctrl/cat_test.c >> @@ -314,7 +314,7 @@ static int noncont_cat_run_test(const struct resctrl_test *test, >> else >> return -EINVAL; >> >> - if (sparse_masks != ((ecx >> 3) & 1)) { >> + if ((get_vendor() == ARCH_INTEL) && sparse_masks != ((ecx >> 3) & 1)) { > This looks independent change to me which should be put into own patch.
Sure. Will do.
Thanks
Babu
| |