Messages in this thread | | | From | Loic Poulain <> | Date | Fri, 26 Apr 2024 14:04:39 +0200 | Subject | Re: [PATCH net v2] net: wwan: Fix missing net device name for error message print |
| |
Hello,
On Fri, 26 Apr 2024 at 11:25, Slark Xiao <slark_xiao@163.com> wrote: > > In my local, I got an error print in dmesg like below: > "sequence number glitch prev=487 curr=0" > After checking, it belongs to mhi_wwan_mbim.c. Refer to the usage > of this net_err_ratelimited() API in other files, I think we > should add net device name print before message context. > > Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")
This is more a cosmetic change than a bugfix, you should target net-next IMO. Also as said in another feedback, the commit message does not match the change, since you're not printing the device name.
| |