Messages in this thread | | | Date | Fri, 26 Apr 2024 19:23:19 +1000 | Subject | Re: [PATCH v7 01/16] ACPI: processor: Simplify initial onlining to use same path for cold and hotplug | From | Gavin Shan <> |
| |
On 4/18/24 23:53, Jonathan Cameron wrote: > Separate code paths, combined with a flag set in acpi_processor.c to > indicate a struct acpi_processor was for a hotplugged CPU ensured that > per CPU data was only set up the first time that a CPU was initialized. > This appears to be unnecessary as the paths can be combined by letting > the online logic also handle any CPUs online at the time of driver load. > > Motivation for this change, beyond simplification, is that ARM64 > virtual CPU HP uses the same code paths for hotplug and cold path in > acpi_processor.c so had no easy way to set the flag for hotplug only. > Removing this necessity will enable ARM64 vCPU HP to reuse the existing > code paths. > > Leave noisy pr_info() in place but update it to not state the CPU > was hotplugged. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > --- > v7: No change. > v6: New patch. > RFT: I have very limited test resources for x86 and other > architectures that may be affected by this change. > --- > drivers/acpi/acpi_processor.c | 1 - > drivers/acpi/processor_driver.c | 44 ++++++++++----------------------- > include/acpi/processor.h | 2 +- > 3 files changed, 14 insertions(+), 33 deletions(-) >
Reviewed-by: Gavin Shan <gshan@redhat.com>
| |