lkml.org 
[lkml]   [2024]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 5/6] soc: qcom: add pd-mapper implementation
From


On 4/24/2024 2:28 AM, Dmitry Baryshkov wrote:

> +static int qcom_pdm_start(void)
> +{
> + const struct of_device_id *match;
> + const struct qcom_pdm_domain_data * const *domains;
> + struct device_node *root;
> + int ret, i;
> +
> + root = of_find_node_by_path("/");
> + if (!root)
> + return -ENODEV;
> +
> + match = of_match_node(qcom_pdm_domains, root);
> + of_node_put(root);
> + if (!match) {
> + pr_notice("PDM: no support for the platform, userspace daemon might be required.\n");
> + return -ENODEV;
> + }
> +
> + domains = match->data;
> + if (!domains) {
> + pr_debug("PDM: no domains\n");
> + return -ENODEV;
> + }
> +
> + mutex_lock(&qcom_pdm_mutex);
> + for (i = 0; domains[i]; i++) {
> + ret = qcom_pdm_add_domain(domains[i]);
> + if (ret)
> + goto free_domains;
> + }
> +
> + ret = qmi_handle_init(&qcom_pdm_handle, 1024,
> + NULL, qcom_pdm_msg_handlers);

1024 here seems arbitrary, I think most other usage of qmi_handle_init
has a macro defined for the max message length of the qmi service.

> + if (ret)
> + goto free_domains;
> +
> + ret = qmi_add_server(&qcom_pdm_handle, SERVREG_LOCATOR_SERVICE,
> + SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE);
> + if (ret) {
> + pr_err("PDM: error adding server %d\n", ret);
> + goto release_handle;
> + }
> + mutex_unlock(&qcom_pdm_mutex);
> +
> + return 0;
> +
> +release_handle:
> + qmi_handle_release(&qcom_pdm_handle);
> +
> +free_domains:
> + qcom_pdm_free_domains();
> + mutex_unlock(&qcom_pdm_mutex);
> +
> + return ret;
> +}
> +
> +static void qcom_pdm_stop(void)
> +{
> + qmi_del_server(&qcom_pdm_handle, SERVREG_LOCATOR_SERVICE,
> + SERVREG_QMI_VERSION, SERVREG_QMI_INSTANCE);
> +
> + qmi_handle_release(&qcom_pdm_handle);
> +

I don't think doing an explicit qmi_del_server() is necessary. As part
of the qmi_handle_release(), the qrtr socket will be closed and the qrtr
ns will broadcast a DEL_SERVER and DEL_CLIENT notification as part of
the cleanup.

> + qcom_pdm_free_domains();
> +}
> +

\
 
 \ /
  Last update: 2024-04-27 01:25    [W:1.867 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site