Messages in this thread | | | Subject | Re: [PATCH v2 1/1] mm: page_alloc: Avoid defining unused function | From | Miaohe Lin <> | Date | Thu, 25 Apr 2024 14:25:24 +0800 |
| |
On 2024/4/24 0:14, Andy Shevchenko wrote: > In some configurations I got > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function] > Becuase the only user is guarged with a certain ifdeffery,
guarged? ifdeffery?
> do the same for add_to_free_list().
A Fixes tag might be needed.
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Anyway, this patch looks good to me. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Thanks. .
| |