Messages in this thread | | | Date | Wed, 24 Apr 2024 06:10:21 -0700 | Subject | Re: [PATCH v2] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional() | From | Wren Turkal <> |
| |
On 4/24/24 5:29 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski<bartosz.golaszewski@linaro.org> > > Any return value from gpiod_get_optional() other than a pointer to a > GPIO descriptor or a NULL-pointer is an error and the driver should > abort probing. That being said: commit 56d074d26c58 ("Bluetooth: hci_qca: > don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets > power_ctrl_enabled on NULL-pointer returned by > devm_gpiod_get_optional(). Restore this behavior but bail-out on errors. > While at it: also bail-out on error returned when trying to get the > "swctrl" GPIO. > > Reported-by: Wren Turkal<wt@penguintechs.org> > Reported-by: Zijun Hu<quic_zijuhu@quicinc.com> > Closes:https://lore.kernel.org/linux-bluetooth/1713449192-25926-2-git-send-email-quic_zijuhu@quicinc.com/ > Fixes: 56d074d26c58 ("Bluetooth: hci_qca: don't use IS_ERR_OR_NULL() with gpiod_get_optional()") > Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@linaro.org> > Signed-off-by: Bartosz Golaszewski<bartosz.golaszewski@linaro.org>
Tested-by: "Wren Turkal" <wt@penguintechs.org>
Like this? wt -- You're more amazing than you think!
| |