lkml.org 
[lkml]   [2024]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v2 01/19] backlight: Constify lcd_ops
    'struct lcd_ops' passed in lcd_device_register() is not modified by core
    backlight code, so it can be made const for code safety. This allows
    drivers to also define the structure as const.

    Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    ---
    drivers/video/backlight/lcd.c | 4 ++--
    include/linux/lcd.h | 6 +++---
    2 files changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
    index ba4771cbd781..ceec90ca758b 100644
    --- a/drivers/video/backlight/lcd.c
    +++ b/drivers/video/backlight/lcd.c
    @@ -191,7 +191,7 @@ static const struct class lcd_class = {
    * or a pointer to the newly allocated device.
    */
    struct lcd_device *lcd_device_register(const char *name, struct device *parent,
    - void *devdata, struct lcd_ops *ops)
    + void *devdata, const struct lcd_ops *ops)
    {
    struct lcd_device *new_ld;
    int rc;
    @@ -279,7 +279,7 @@ static int devm_lcd_device_match(struct device *dev, void *res, void *data)
    */
    struct lcd_device *devm_lcd_device_register(struct device *dev,
    const char *name, struct device *parent,
    - void *devdata, struct lcd_ops *ops)
    + void *devdata, const struct lcd_ops *ops)
    {
    struct lcd_device **ptr, *lcd;

    diff --git a/include/linux/lcd.h b/include/linux/lcd.h
    index 238fb1dfed98..68703a51dc53 100644
    --- a/include/linux/lcd.h
    +++ b/include/linux/lcd.h
    @@ -61,7 +61,7 @@ struct lcd_device {
    points to something in the body of that driver, it is also invalid. */
    struct mutex ops_lock;
    /* If this is NULL, the backing module is unloaded */
    - struct lcd_ops *ops;
    + const struct lcd_ops *ops;
    /* Serialise access to set_power method */
    struct mutex update_lock;
    /* The framebuffer notifier block */
    @@ -102,10 +102,10 @@ static inline void lcd_set_power(struct lcd_device *ld, int power)
    }

    extern struct lcd_device *lcd_device_register(const char *name,
    - struct device *parent, void *devdata, struct lcd_ops *ops);
    + struct device *parent, void *devdata, const struct lcd_ops *ops);
    extern struct lcd_device *devm_lcd_device_register(struct device *dev,
    const char *name, struct device *parent,
    - void *devdata, struct lcd_ops *ops);
    + void *devdata, const struct lcd_ops *ops);
    extern void lcd_device_unregister(struct lcd_device *ld);
    extern void devm_lcd_device_unregister(struct device *dev,
    struct lcd_device *ld);
    --
    2.43.0


    \
     
     \ /
      Last update: 2024-04-24 08:35    [W:3.582 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site