| Date | Wed, 24 Apr 2024 21:39:04 -0700 | Subject | Re: [PATCH v3 11/16] selftests/resctrl: Add ->init() callback into resctrl_val_param | From | Reinette Chatre <> |
| |
Hi Ilpo,
On 4/8/2024 9:32 AM, Ilpo Järvinen wrote: > The struct resctrl_val_param is there to customize behavior inside > resctrl_val() which is currently not used to full extent and there are > number of strcmp()s for test name in resctrl_val done by resctrl_val(). > > Create ->init() hook into the struct resctrl_val_param to cleanly > do per test initialization. > > Remove also unused branches to setup paths and the related #defines > for CMT test.
All these code being moved have a similar pattern to earlier code that was deleted. It seems to me as though the CMT may also unnecessarily create a monitor group and have the same opportunity to remove some of the code being moved around here.
It is starting to look like resctrl_val_param->mongrp is not necessary.
Reinette
|