lkml.org 
[lkml]   [2024]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2 4/4] perf record off-cpu: delete bound-to-fail test
Date
Since `--off-cpu` now uses the same ring buffer as hardware samples,
but `perf record --off-cpu -e dummy sleep 1`does not enable evlist,
off-cpu samples cannot be read.`test_offcpu_basic` fails and is no
longer necessary.

Signed-off-by: Howard Chu <howardchu95@gmail.com>
---
tools/perf/tests/shell/record_offcpu.sh | 29 -------------------------
1 file changed, 29 deletions(-)

diff --git a/tools/perf/tests/shell/record_offcpu.sh b/tools/perf/tests/shell/record_offcpu.sh
index 67c925f3a15a..c446c0cdee4f 100755
--- a/tools/perf/tests/shell/record_offcpu.sh
+++ b/tools/perf/tests/shell/record_offcpu.sh
@@ -36,30 +36,6 @@ test_offcpu_priv() {
fi
}

-test_offcpu_basic() {
- echo "Basic off-cpu test"
-
- if ! perf record --off-cpu -e dummy -o ${perfdata} sleep 1 2> /dev/null
- then
- echo "Basic off-cpu test [Failed record]"
- err=1
- return
- fi
- if ! perf evlist -i ${perfdata} | grep -q "offcpu-time"
- then
- echo "Basic off-cpu test [Failed no event]"
- err=1
- return
- fi
- if ! perf report -i ${perfdata} -q --percent-limit=90 | grep -E -q sleep
- then
- echo "Basic off-cpu test [Failed missing output]"
- err=1
- return
- fi
- echo "Basic off-cpu test [Success]"
-}
-
test_offcpu_child() {
echo "Child task off-cpu test"

@@ -88,13 +64,8 @@ test_offcpu_child() {
echo "Child task off-cpu test [Success]"
}

-
test_offcpu_priv

-if [ $err = 0 ]; then
- test_offcpu_basic
-fi
-
if [ $err = 0 ]; then
test_offcpu_child
fi
--
2.44.0

\
 
 \ /
  Last update: 2024-04-24 04:49    [W:0.073 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site