lkml.org 
[lkml]   [2024]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4] mfd: intel-lpss: Utilize i2c-designware.h
From


On 4/23/2024 5:00 PM, Andy Shevchenko wrote:
> Tue, Apr 23, 2024 at 04:36:20PM -0700, Florian Fainelli kirjoitti:
>> Rather than open code the i2c_designware string, utilize the newly
>> defined constant in i2c-designware.h.
>
> ...
>
>> static const struct mfd_cell intel_lpss_i2c_cell = {
>> - .name = "i2c_designware",
>> + .name = I2C_DESIGNWARE_NAME,
>> .num_resources = ARRAY_SIZE(intel_lpss_dev_resources),
>> .resources = intel_lpss_dev_resources,
>> };
>
> We have tons of drivers that are using explicit naming, why is this case
> special?
>

It is not special, just one of the 3 cases outside of drivers/i2c/busses
that reference a driver living under drivers/i2c/busses, as I replied in
the cover letter, this is a contract between the various device drivers
and their users, so we should have a central place where it is defined,
not repeated.
--
Florian
[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2024-04-24 05:20    [W:0.069 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site