lkml.org 
[lkml]   [2024]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/19] Enable -Wshadow=local for kernel/sched
*thread necromancy*

On Wed, Mar 02, 2022 at 04:34:32AM +0000, Matthew Wilcox (Oracle) wrote:
> I thought I'd choose one of the more core parts of the kernel to
> demonstrate the value of -Wshadow. It found two places where there are
> shadowed variables that are at least confusing. For all I know they're
> buggy and my resolution of these warnings is wrong.
>
> The first 12 patches just untangle the unclean uses of __ret in wait.h
> & friends. Then 4 patches to fix problems in headers that are noticed
> by kernel/sched. Two patches fix the two places in kernel/sched/
> with shadowed variables and the final patch adds -Wshadow=local to
> the Makefile.
>
> I'm quite certain this patch series isn't going in as-is. But maybe
> it'll inspire some patches that can go in.

I was looking at -Wshadow=local again, and remembered this series. It
sounded like things were close, but a tweak was needed. What would be
next to get this working?

Thanks!

-Kees

--
Kees Cook

\
 
 \ /
  Last update: 2024-04-16 23:15    [W:0.121 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site