lkml.org 
[lkml]   [2024]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: vc04_services: Code optimized to use linux BIT macro.
On Sun, Apr 14, 2024 at 03:42:58PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
>
> Signed-off-by: sumadhura kalyan <opensourcecond@gmail.com>
> ---
> drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> index a0cdd28101f2..d811bfd3bb84 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> @@ -27,7 +27,7 @@
> /** Common parameter ID group, used with many types of component. */
> #define MMAL_PARAMETER_GROUP_COMMON (0 << 16)
> /** Camera-specific parameter ID group. */
> -#define MMAL_PARAMETER_GROUP_CAMERA (1 << 16)
> +#define MMAL_PARAMETER_GROUP_CAMERA BIT(16)
> /** Video-specific parameter ID group. */
> #define MMAL_PARAMETER_GROUP_VIDEO (2 << 16)
> /** Audio-specific parameter ID group. */

When looking at the code now, does this change make sense? Remember,
checkpatch is a guide, not a hard rule.

greg k-h

\
 
 \ /
  Last update: 2024-05-27 16:40    [W:2.023 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site