lkml.org 
[lkml]   [2024]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND] HID: sony: Remove usage of the deprecated ida_simple_xx() API
    Date
    ida_alloc() and ida_free() should be preferred to the deprecated
    ida_simple_get() and ida_simple_remove().

    This is less verbose.

    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    ---
    This patch has been sent about 3 months ago [1].
    A gentle reminder has been sent 1 month later [2].

    Neither one got any reply.

    So, I'm adding Andrew Morton in To:, in order to help in the merge process.

    Context:
    =======
    All patches to remove the ida_simple API have been sent.
    Matthew Wilcox seems happy with the on going work. (see [3])

    Based on next-20240412
    $git grep ida_simple_get | wc -l
    25

    Based on next-20240220
    $git grep ida_simple_get | wc -l
    36

    https://elixir.bootlin.com/linux/v6.8-rc3/A/ident/ida_simple_get
    50

    https://elixir.bootlin.com/linux/v6.7.4/A/ident/ida_simple_get
    81

    Thanks
    CJ

    [1]: https://lore.kernel.org/all/9c092dc6db15984d98732510bb052bb00683489b.1705005258.git.christophe.jaillet@wanadoo.fr/https://lore.kernel.org/all/19b538bc05c11747a3dd9fa204fde91942063d52.1698831460.git.christophe.jaillet@wanadoo.fr/
    [2]: https://lore.kernel.org/all/a1af20a9-951f-4a5d-8a60-04ded8d6f9a0@wanadoo.fr/
    [3]: https://lore.kernel.org/all/ZaqruGVz734zjxrZ@casper.infradead.org/
    ---
    drivers/hid/hid-sony.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
    index ebc0aa4e4345..55c0ad61d524 100644
    --- a/drivers/hid/hid-sony.c
    +++ b/drivers/hid/hid-sony.c
    @@ -1844,8 +1844,7 @@ static int sony_set_device_id(struct sony_sc *sc)
    * All others are set to -1.
    */
    if (sc->quirks & SIXAXIS_CONTROLLER) {
    - ret = ida_simple_get(&sony_device_id_allocator, 0, 0,
    - GFP_KERNEL);
    + ret = ida_alloc(&sony_device_id_allocator, GFP_KERNEL);
    if (ret < 0) {
    sc->device_id = -1;
    return ret;
    @@ -1861,7 +1860,7 @@ static int sony_set_device_id(struct sony_sc *sc)
    static void sony_release_device_id(struct sony_sc *sc)
    {
    if (sc->device_id >= 0) {
    - ida_simple_remove(&sony_device_id_allocator, sc->device_id);
    + ida_free(&sony_device_id_allocator, sc->device_id);
    sc->device_id = -1;
    }
    }
    --
    2.44.0

    \
     
     \ /
      Last update: 2024-05-27 16:40    [W:9.469 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site