lkml.org 
[lkml]   [2024]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v6 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver
    Sat, Mar 23, 2024 at 08:15:17PM +0800, Peng Fan (OSS) kirjoitti:
    > From: Peng Fan <peng.fan@nxp.com>
    >
    > scmi-pinctrl driver implements pinctrl driver interface and using
    > SCMI protocol to redirect messages from pinctrl subsystem SDK to
    > SCMI platform firmware, which does the changes in HW.

    ..

    > +#include <linux/device.h>
    > +#include <linux/err.h>
    > +#include <linux/module.h>
    > +#include <linux/seq_file.h>
    > +#include <linux/scmi_protocol.h>
    > +#include <linux/slab.h>

    Use IWYU principle. There are missing header inclusions and/or forward
    declarations.

    ..

    > +struct scmi_pinctrl_funcs {
    > + unsigned int num_groups;
    > + const char **groups;
    > +};

    This is repeating struct pinfunction. Why can't the latter be used?

    ..

    > +err_free:
    > + devm_kfree(pmx->dev, groups);

    Why?!

    This is 99.9% that the initial allocation must not be devm.

    ..

    > + *p_config_value = kcalloc(num_configs, sizeof(u32), GFP_KERNEL);

    sizeof(**p_config_value)?

    > + *p_config_type = kcalloc(num_configs,
    > + sizeof(enum scmi_pinctrl_conf_type),

    sizeof(**p_config_type)?

    > + GFP_KERNEL);
    > +
    > + if (!*p_config_value || !*p_config_type) {
    > + kfree(*p_config_value);
    > + kfree(*p_config_type);
    > + return -ENOMEM;

    Why to allocate / free memory in the case when you know that the first one
    failed?

    > + }

    ..

    > +static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx,
    > + struct pinctrl_desc *desc)
    > +{
    > + struct pinctrl_pin_desc *pins;
    > + unsigned int npins;
    > + int ret, i;
    > +
    > + npins = pinctrl_ops->count_get(pmx->ph, PIN_TYPE);
    > + pins = devm_kmalloc_array(pmx->dev, npins, sizeof(*pins), GFP_KERNEL);
    > + if (!pins)
    > + return -ENOMEM;
    > +
    > + for (i = 0; i < npins; i++) {
    > + pins[i].number = i;
    > + ret = pinctrl_ops->name_get(pmx->ph, i, PIN_TYPE, &pins[i].name);
    > + if (ret)
    > + return dev_err_probe(pmx->dev, ret,
    > + "Can't get name for pin %d", i);
    > + }
    > +
    > + desc->npins = npins;
    > + desc->pins = pins;
    > + dev_dbg(pmx->dev, "got pins %d", npins);

    %u

    > + return 0;
    > +}

    ..

    > + pinctrl_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL,
    > + &ph);

    One line.

    > + if (IS_ERR(pinctrl_ops))
    > + return PTR_ERR(pinctrl_ops);

    --
    With Best Regards,
    Andy Shevchenko



    \
     
     \ /
      Last update: 2024-03-29 20:10    [W:3.883 / U:1.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site