Messages in this thread | | | Date | Fri, 29 Mar 2024 01:56:24 +1100 | From | John Watts <> | Subject | Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats |
| |
On Thu, Mar 28, 2024 at 01:56:42PM +0000, Mark Brown wrote: > On Thu, Mar 28, 2024 at 01:21:21PM +1100, John Watts wrote: > > On Wed, Mar 27, 2024 at 08:53:32PM +0100, Jernej Škrabec wrote: > > > > I wish it would be that simple. SUN4I_FORMATS is cross section of all I2S > > > variants that are supported by this driver. If you check A10, you'll see that > > > it doesn't support S32. > > > > If you want to add support for S32, you'll have to add new quirk for each > > > variant. > > > Yes, A10 doesn't support it. But it should error out in hw_params due to > > get_sr not supporting 32-bit, no? > > The constraints shouldn't be advertising things that hw_params() will > error out on, sometimes there are contingent constraints that prevent > this but something that just doesn't work isn't one of those times.
Oh right! I'm not sure how I forgot about this, given I went through this exact discussion for my wm8782 patch.
I'll try and get v2 patch for this soon. :)
John.
| |