Messages in this thread | | | From | Ian Rogers <> | Date | Thu, 28 Mar 2024 09:36:30 -0700 | Subject | Re: [RFC PATCH v5 0/6] TPEBS counting mode support |
| |
On Tue, Mar 26, 2024 at 1:29 PM <weilin.wang@intel.com> wrote: > > From: Weilin Wang <weilin.wang@intel.com> > > Changes in v5: > - Update code and add comments for better code quality [Ian] > > v4: https://lore.kernel.org/all/20240312234921.812685-1-weilin.wang@intelcom/ > > Weilin Wang (6): > perf stat: Parse and find tpebs events when parsing metrics to prepare > for perf record sampling > perf stat: Fork and launch perf record when perf stat needs to get > retire latency value for a metric. > perf stat: Add retire latency values into the expr_parse_ctx to > prepare for final metric calculation > perf stat: Create another thread for sample data processing > perf stat: Add retire latency print functions to print out at the very > end of print out > perf vendor events intel: Add MTL metric json files > > tools/perf/builtin-stat.c | 211 +- > .../arch/x86/meteorlake/metricgroups.json | 127 + > .../arch/x86/meteorlake/mtl-metrics.json | 2551 +++++++++++++++++ > tools/perf/util/data.c | 3 + > tools/perf/util/data.h | 5 + > tools/perf/util/metricgroup.c | 88 +- > tools/perf/util/metricgroup.h | 22 +- > tools/perf/util/stat-display.c | 65 + > tools/perf/util/stat-shadow.c | 19 + > tools/perf/util/stat.h | 4 + > 10 files changed, 3076 insertions(+), 19 deletions(-) > create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/metricgroups.json > create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-metricsjson
Thanks Weilin,
I'm happy with this series, my Reviewed-by is on all the patches. Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric enablement? For the sake of tools, for the series:
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, Ian
> -- > 2.43.0 >
| |