Messages in this thread | | | Date | Thu, 28 Mar 2024 09:01:33 -0700 | Subject | Re: [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro | From | Jeff Johnson <> |
| |
On 3/27/2024 7:21 PM, Barry Song wrote: > From: Xining Xu <mac.xxn@outlook.com> > > If function-like macros do not utilize a parameter, it might result in a > build warning. In our coding style guidelines, we advocate for utilizing > static inline functions to replace such macros. This patch verifies > compliance with the new rule. > > For a macro such as the one below, > > #define test(a) do { } while (0) > > The test result is as follows. > > ERROR: Parameter 'a' is not used in function-like macro, please use static > inline instead > #21: FILE: mm/init-mm.c:20: > +#define test(a) do { } while (0) > > total: 1 errors, 0 warnings, 8 lines checked > > Signed-off-by: Xining Xu <mac.xxn@outlook.com>
if you are re-posting somebody else's work you need to add your own Signed-off-by
> Tested-by: Barry Song <v-songbaohua@oppo.com> > Cc: Chris Zankel <chris@zankel.net> > Cc: Huacai Chen <chenhuacai@loongson.cn> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Stephen Rothwell <sfr@canb.auug.org.au> > Cc: Mark Brown <broonie@kernel.org> > Cc: Andy Whitcroft <apw@canonical.com> > Cc: Dwaipayan Ray <dwaipayanray1@gmail.com> > Cc: Joe Perches <joe@perches.com> > Cc: Jonathan Corbet <corbet@lwn.net> > Cc: Lukas Bulwahn <lukas.bulwahn@gmail.com> > Cc: Max Filippov <jcmvbkbc@gmail.com>
| |