Messages in this thread | | | Date | Thu, 28 Mar 2024 16:42:17 +0100 | Subject | Re: [PATCH] dt-bindings: arm: qcom: Add Samsung Galaxy Z Fold5 | From | Alexandru Serdeliuc <> |
| |
Is there anything I need to do to sent them as a series? Or only modify all 3 files on a new branch and send them as a new patch?
The situation can be replicated easy, modify the following two files
Documentation/devicetree/bindings/arm/qcom.yaml arch/arm64/boot/dts/qcom/Makefile
Then generate the pach and check, will show this $ ./scripts/checkpatch.pl /tmp/tosend2/0001-arm64-dts-qcom-add-support-for-samsung-galaxy-z-fold5.eml WARNING: Missing commit description - Add an appropriate one
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #59: new file mode 100644
total: 0 errors, 3 warnings, 630 lines checked
NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace.
/tmp/tosend2/0001-arm64-dts-qcom-add-support-for-samsung-galaxy-z-fold5.eml has style problems, please review.
NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
On 28/3/24 16:34, Konrad Dybcio wrote: > On 28.03.2024 4:10 PM, Alexandru Serdeliuc wrote: >> Hi Konrad, >> >> Thanks, I unfortunately sent the patch 2 prior seeing your reply. >> >> The warning was this one which says that i need to send the mods separately in two patches: >> >>>>> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > Hm, if they were two separate patches, this is a false-positive. Could you > push the branch somewhere, so that we can report it to checkpatch maintainers? > >> >> I suppose that me sending two separate patches was not good, how i can fix this? > Please pick them both onto a single branch and send together as a series, > with a revision bump (v2) and mention that you made no changes other than > combining the two in the cover letter. > > Konrad
| |