Messages in this thread | | | Date | Thu, 28 Mar 2024 17:32:24 +0200 | Subject | Re: [PATCH v2 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver | From | Dmitry Baryshkov <> |
| |
On 26/03/2024 01:42, Pavan Holla wrote: > Implementation of transport driver for UCSI. This driver will be used > if the ChromeOS EC implements a PPM. > > Signed-off-by: Pavan Holla <pholla@chromium.org> > --- > drivers/platform/chrome/Kconfig | 14 ++ > drivers/platform/chrome/Makefile | 1 + > drivers/platform/chrome/cros_ec_ucsi.c | 247 +++++++++++++++++++++++++ > include/linux/platform_data/cros_ec_commands.h | 19 ++
While it's fine to use platform/chrome for platform drivers, please place drivers which have a subsystem into the subsystem dir. I think we don't want to hunt UCSI implementations all over the codebase. Please use drivers/usb/typec/ucsi/ location for your driver. This also removes a need for a global header.
-- With best wishes Dmitry
| |