Messages in this thread | | | Date | Thu, 28 Mar 2024 15:22:07 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v5 2/2] ASoC: nau8325: new driver |
| |
On Wed, Mar 27, 2024 at 03:57:55PM +0800, Seven Lee wrote:
> +static const char * const nau8325_dac_oversampl[] = { > + "64", "256", "128", "", "32" }; > + > +static const struct soc_enum nau8325_dac_oversampl_enum = > + SOC_ENUM_SINGLE(NAU8325_R29_DAC_CTRL1, NAU8325_DAC_OVERSAMPLE_SFT, > + ARRAY_SIZE(nau8325_dac_oversampl), > + nau8325_dac_oversampl);
This should really be a SOC_VALUE_ENUM so you can just hide the fourth value rather than having the empty (presumably invalid) option. Please send an incremental patch doing this. [unhandled content-type:application/pgp-signature] | |