lkml.org 
[lkml]   [2024]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 0/2] sched: Minor changes for rd->overload access
From


On 3/28/24 4:04 PM, Ingo Molnar wrote:
>
> * Shrikanth Hegde <sshegde@linux.ibm.com> wrote:
>

>>
>> Hi Ingo.
>>
>> These two patches apply cleanly now to sched/core.
>>
>> 7a9dd7ef946c (HEAD -> sched/core) sched/fair: Use helper functions to access rd->overload
>> 4f24aa918558 sched/fair: Check rd->overload value before update
>> c829d6818b60 (origin/sched/core) sched/fair: Simplify the continue_balancing logic in sched_balance_newidle()
>> d0f5d3cefc25 sched/fair: Introduce is_rd_overutilized() helper function to access root_domain::overutilized
>
> I've applied them, but note that there were quite a few avoidable typos
> and grammar mistakes in the changelogs. Please always review what
> you've submitted versus what I have applied and try to learn from that:
> I almost invariable have to edit some detail to make the changelog more
> presentable... Could you please take more care with future patches?
>

Noted.
I will learn for it, thank you.

> I also renamed the accessor functions in the second patch to:
>
> get_rd_overload()
> set_rd_overload()
>
> Plus I've applied a patch to rename ::overload to ::overloaded. It is
> silly to use an ambiguous noun instead of a clear adjective when naming
> such a flag ...
>

sure. looks fine.

> Thanks,
>
> Ingo

\
 
 \ /
  Last update: 2024-05-27 16:13    [W:0.107 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site