Messages in this thread | | | Date | Thu, 28 Mar 2024 12:25:49 +0000 | From | Simon Horman <> | Subject | Re: [PATCH v3 RESEND] net: hsr: Provide RedBox support |
| |
On Tue, Mar 26, 2024 at 10:02:20AM +0100, Lukasz Majewski wrote: > Introduce RedBox support (HSR-SAN to be more precise) for HSR networks. > Following traffic reduction optimizations have been implemented: > - Do not send HSR supervisory frames to Port C (interlink) > - Do not forward to HSR ring frames addressed to Port C > - Do not forward to Port C frames from HSR ring > - Do not send duplicate HSR frame to HSR ring when destination is Port C > > The corresponding patch to modify iptable2 sources has already been sent: > https://lore.kernel.org/netdev/20240308145729.490863-1-lukma@denx.de/T/ > > Testing procedure: > ------------------ > The EVB-KSZ9477 has been used for testing on net-next branch > (SHA1: 709776ea8562). > > Ports 4/5 were used for SW managed HSR (hsr1) as first hsr0 for ports 1/2 > (with HW offloading for ksz9477) was created. Port 3 has been used as > interlink port (single USB-ETH dongle). > > Configuration - RedBox (EVB-KSZ9477): > ifconfig lan1 down;ifconfig lan2 down > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1 > ip link add name hsr1 type hsr slave1 lan4 slave2 lan5 interlink lan3 supervision 45 version 1 > ifconfig lan4 up;ifconfig lan5 up > ifconfig lan3 up > ifconfig hsr1 192.168.0.11 up > > Configuration - DAN-H (EVB-KSZ9477): > > ifconfig lan1 down;ifconfig lan2 down > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision 45 version 1 > ip link add name hsr1 type hsr slave1 lan4 slave2 lan5 supervision 45 version 1 > ifconfig lan4 up;ifconfig lan5 up > ifconfig hsr1 192.168.0.12 up > > This approach uses only SW based HSR devices (hsr1). > > -------------- ----------------- ------------ > DAN-H Port5 | <------> | Port5 | | > Port4 | <------> | Port4 Port3 | <---> | PC > | | (RedBox) | | (USB-ETH) > EVB-KSZ9477 | | EVB-KSZ9477 | | > -------------- ----------------- ------------ > > Signed-off-by: Lukasz Majewski <lukma@denx.de>
Hi Lukasz,
this patch (2) seems to have a build dependency on: (1) [v2,RESEND] net: hsr: Use full string description when opening HSR network device https://lore.kernel.org/all/20240326085649.3259424-1-lukma@denx.de/
Which is pending review.
With this in mind, I suggest waiting for the review of 1 to be completed and then either:
* If 1 is accepted, then follow-up by sending v4 of this patch (2); or * If changes are requested to 1, include 1 and 2 together in a patchset after addressing relevant feedback
..
| |